erisu edited a comment on pull request #1189: URL: https://github.com/apache/cordova-android/pull/1189#issuecomment-810683881
I have not experienced any issues with this change. I have even been told that one developer had tested the current master (6.1) and had successful builds. The versioning states that it is a minor version, and same goes for all the other revert PRs. For example, Gradle does sometimes mention potential breaking changes when upgrading to each latest release of 6.x. But in each release note for each version, I don't see them clearly stating that these xyz are breaking changes. Maybe that potential breaking changes section in the upgrading page is their statement of breaking changes? It is a little concerning if we can't rely on the versioning system. * Google has created breaking changes once before in a minor release, they dropped ASL for Android X in the Firebase library. * TypeScript introduces breaking changes in minor releases. They do not following semver and is on npm (which we suspect would follow semver) Really, should we start to consider ALL minor releases from all packages, no matter where it comes from, to be a major release for Cordova? I never seen on any libraries website cleary states, "We follow semver". Even if they dont say it is breaking change, a refactor, a fix, or an introduction of a feature can always potentially lead to a break somewhere else in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
