breautek commented on a change in pull request #215: URL: https://github.com/apache/cordova-plugin-media-capture/pull/215#discussion_r613998625
########## File path: plugin.xml ########## @@ -71,6 +71,7 @@ xmlns:android="http://schemas.android.com/apk/res/android"; <!-- android --> <platform name="android"> <config-file target="res/xml/config.xml" parent="/*"> + <preference name="AndroidXEnabled" value="true" /> Review comment: > But I think the app that is used for the automated tests is using the old version. Removing this flag will fail the tests. I think we can leave this in for now just for the sake of using the automated tests. Once `cordova-android@10` is released, it can be removed, as the automated tests will start using `cordova-android@10`, which should work without adding this preference. We'll need to also update the engines on this plugin so that older versions of plugin cannot be used on `cordova-android@`10`, and version 4 of this plugin is required if using `cordova-android@10`, but this can be done as a separate independent PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
