ath0mas opened a new pull request #1100: URL: https://github.com/apache/cordova-ios/pull/1100
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Mixed default values for `create` between cli doc, cordova-android and cordova-ios. ### Description <!-- Describe your changes in detail --> Package ids were mostly correct but not all, and same for project name. Suggested proper defaults: - **id** / package name: `io.cordova.helloCordova` - **name** / project name: `Hello Cordova` See linked PRs: apache/cordova-cli#554 And - mimic code from _cordova-android_ for `createProject` on how to init and deal with its parameters - remove useless _check on project_parent_ as `fs.ensureDirSync` is used _(see each commit for detail on my steps)_ ### Testing <!-- Please describe in detail how you tested your changes. --> `npm test` success ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
