NiklasMerz commented on pull request #1172:
URL: https://github.com/apache/cordova-docs/pull/1172#issuecomment-833416829


   > I've fixed the merge conflicts after merging my PR that removed the 
AndroidX preference.
   > I edited right before you commented, so you probably didn't see, can you 
add the preference to the examples section too?
   
   Done
   
   > If you don't want to go into detail about the data loss in this PR it's 
ok, but it should still be about **loading** from file instead of **accessing** 
file urls, because it's not the same thing.
   
   I changed the wording and found the right page to describe that. Maybe 
others can jump in and help to improve it.
    
   > If you load from file url, you obviously need to access file urls, but you 
might still want to load from https and access file urls (i.e. take a picture 
from the camera and assign it to a img tag) and can wrongly enable this 
preference to do so.
   > 
   > BTW, that example made me think, do we have some helper like on iOS to 
convert file urls like the one you get from camera to https urls? would the 
assets loader be able to load those urls somehow?
   
   TBH I don't really what happens with camera and other files. Maybe it still 
works? I need to test it out.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to