flexaddicted opened a new pull request #874:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/874


   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   iOS
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   The changes proposed through this PR have been introduced to make easier the 
management of the User Interface through Auto Layout. In fact, Auto Layout is 
now the de facto standard to handle layout in iOS.
   Additionally the creation of the components has been refactored in order to 
have identify clearly them within the code.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   These are the changes in detail:
   
   - Replace frame based layout with Auto Layout.
   - Create separate methods used to create all the elements of the user 
interface.
   - Add an additional property, called `extendwebviewtobottom`, to extend the 
web view besides the bottom safe area.
   - Code cleanup.
   - Remove unused or deprecated code.
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   I've tested all the possible configuration available with the web UI.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to