PieterVanPoyer commented on issue #711: URL: https://github.com/apache/cordova-plugin-camera/issues/711#issuecomment-847287766
Hey @SnpDeveloper So, the heic works just fine with the PR. About your observations and thoughts. I agree with it mostly. But for this issue, I'd just like to fix and focus on the heic case. Fix and focus on the original issue. For the other types, the behaviour is the same as before. (The original image and type is returned for Android) So it's a small improvement now. If we decide to convert the other types to the encodingType too, it's more a breaking change. And I am not willing to take that risk now, it needs a little more discussion with other people I think. _I suggest you make another issue for that._ And I agree/assume that should be the purpose of the encodingType. Hey @CGS38 Are you able to test this PR? And leave your testing results? ``` npx cordova plugin remove cordova-plugin-camera npx cordova plugin add https://github.com/PieterVanPoyer/cordova-plugin-camera/#feature/issue-711-heif-format ``` Kind regards Pieter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
