wedgberto commented on a change in pull request #1154:
URL: https://github.com/apache/cordova-android/pull/1154#discussion_r650822249
##########
File path: bin/templates/cordova/lib/prepare.js
##########
@@ -251,24 +250,20 @@ function updateProjectAccordingTo (platformConfig,
locations) {
const destFile = java_files[0];
- // var destFile = path.join(locations.root, 'app', 'src', 'main', 'java',
androidPkgName.replace(/\./g, '/'), path.basename(java_files[0]));
- // fs.ensureDirSync(path.dirname(destFile));
- // events.emit('verbose', java_files[0]);
- // events.emit('verbose', destFile);
- // console.log(locations);
- // fs.copySync(java_files[0], destFile);
- utils.replaceFileContents(destFile, /package [\w.]*;/, 'package ' +
androidPkgName + ';');
- events.emit('verbose', 'Wrote out Android package name "' + androidPkgName
+ '" to ' + destFile);
-
- var removeOrigPkg = checkReqs.isWindows() || checkReqs.isDarwin()
- ? manifestId.toUpperCase() !== androidPkgName.toUpperCase()
- : manifestId !== androidPkgName;
-
- if (removeOrigPkg) {
Review comment:
rather than using a completely different set of rules to determine
whether to delete the **essential** Android Activity class source code file,
this change relocates the file when the package name is changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
