jcesarmobile commented on a change in pull request #1252:
URL: https://github.com/apache/cordova-android/pull/1252#discussion_r662892525
##########
File path: bin/templates/cordova/lib/plugin-build.gradle
##########
@@ -20,8 +20,8 @@
buildscript {
repositories {
+ mavenCentral()
google()
Review comment:
I think there have been problems in the past with mavenCentral not
finding google dependencies and it's preferred to have google() on top
##########
File path: framework/build.gradle
##########
@@ -94,72 +87,58 @@ android {
}
}
-install {
- repositories.mavenInstaller {
- pom {
- project {
- packaging 'aar'
- name 'Cordova'
- url 'https://cordova.apache.org'
+task sourcesJar(type: Jar) {
+ from android.sourceSets.main.java.srcDirs
+ classifier = 'sources'
+}
+
+publishing {
+ publications {
+ Cordova(MavenPublication) {
+ groupId = 'org.apache.cordova'
+ artifactId = 'framework'
+ version = '10.0.0-dev'
+
+ artifact(sourcesJar)
+
+ pom {
+ name = 'Cordova'
+ description = 'A library to build Cordova-based projects for
the Android platform.'
+ url = 'https://cordova.apache.org'
+
licenses {
license {
- name 'The Apache Software License, Version 2.0'
- url 'http://www.apache.org/licenses/LICENSE-2.0.txt'
+ name = 'Apache License, Version 2.0'
+ url =
'https://www.apache.org/licenses/LICENSE-2.0.txts'
Review comment:
```suggestion
url =
'https://www.apache.org/licenses/LICENSE-2.0.txt'
```
invalid url, has an extra s
##########
File path: bin/templates/project/repositories.gradle
##########
@@ -17,6 +17,6 @@
*/
ext.repos = {
+ mavenCentral()
Review comment:
same
##########
File path: test/androidx/app/build.gradle
##########
@@ -56,5 +56,6 @@ dependencies {
})
}
repositories {
- jcenter()
+ mavenCentral()
Review comment:
same
##########
File path: framework/repositories.gradle
##########
@@ -17,6 +17,6 @@
*/
ext.repos = {
+ mavenCentral()
Review comment:
same
##########
File path: spec/fixtures/android_studio_project/build.gradle
##########
@@ -15,8 +15,8 @@ buildscript {
allprojects {
repositories {
+ mavenCentral()
Review comment:
same
##########
File path: test/androidx/build.gradle
##########
@@ -34,8 +34,8 @@ buildscript {
allprojects {
repositories {
+ mavenCentral()
Review comment:
same
##########
File path: framework/cordova.gradle
##########
@@ -171,10 +171,11 @@ ext {
buildscript {
repositories {
- jcenter()
+ mavenCentral()
Review comment:
same
##########
File path: spec/fixtures/android_studio_project/build.gradle
##########
@@ -2,8 +2,8 @@
buildscript {
repositories {
+ mavenCentral()
Review comment:
same
##########
File path: test/androidx/build.gradle
##########
@@ -20,8 +20,8 @@
buildscript {
repositories {
+ mavenCentral()
Review comment:
same
##########
File path: bin/templates/project/app/repositories.gradle
##########
@@ -19,5 +19,4 @@
ext.repos = {
mavenCentral()
Review comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
