erisu commented on a change in pull request #1212:
URL: https://github.com/apache/cordova-android/pull/1212#discussion_r663476050
##########
File path: spec/unit/prepare.spec.js
##########
@@ -783,6 +783,20 @@ describe('prepare', () => {
Api = rewire('../../bin/templates/cordova/Api');
prepare = rewire('../../bin/templates/cordova/lib/prepare');
+ prepare.__set__('require.resolve', (file) => {
+ if (file === 'cordova-android/framework/defaults.json') {
+ return path.resolve('./framework/defaults.json');
+ }
+ return path.resolve(file);
+ });
+
+ const defaults = require('../../framework/defaults.json');
+
+ prepare.__set__('fs', {
+ readJSONSync: () => defaults,
Review comment:
We can remove the test and figure something else out in the future.
We need to push forward with the release since we have less then a month
before Google's Playstore new hard requirements. We should get something
released as soon as possible to get user feedback on bugs. Rather not have
tests holding the release back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
