raphinesse commented on a change in pull request #860:
URL: https://github.com/apache/cordova-lib/pull/860#discussion_r716220531
##########
File path: src/cordova/util.js
##########
@@ -301,14 +301,26 @@ function isDirectory (dir) {
// Returns the API of the platform contained in `dir`.
// Potential errors : module isn't found, can't load or doesn't implement the
expected interface.
-function getPlatformApiFunction (dir) {
+function getPlatformApiFunction (dir, platform) {
let PlatformApi;
try {
+ // First try to load the platform API from the platform project
+ // This is necessary to support older platform API versions
PlatformApi = exports.requireNoCache(dir);
} catch (err) {
- // Module not found or threw error during loading
- err.message = `Unable to load Platform API from
${dir}:\n${err.message}`;
- throw err;
+ try {
+ let cdvPlatform = platform;
+ if (!platform.startsWith('cordova-')) {
+ cdvPlatform = `cordova-${platform}`;
+ }
Review comment:
Different way to do the same thing:
```suggestion
const cdvPlatform = platform.replace(/^(?:cordova-)?/,
'cordova-');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
