breautek commented on a change in pull request #1177:
URL: https://github.com/apache/cordova-docs/pull/1177#discussion_r724155427



##########
File path: www/docs/en/10.x/guide/platforms/android/index.md
##########
@@ -116,8 +116,9 @@ should be updated:
    installation
 2. Set the `ANDROID_SDK_ROOT` environment variable to the location of your 
Android
    SDK installation
-3. It is also recommended that you add the Android SDK's `tools`, `tools/bin`,
+3. It is also recommended that you add the Android SDK's `tools/bin`, 
`emulator`

Review comment:
       ```suggestion
   3. It is also recommended that you add the Android SDK's 
`cmdline-tools/latest/bin`, `emulator`
   ```

##########
File path: www/docs/en/10.x/guide/platforms/android/index.md
##########
@@ -133,7 +134,7 @@ To update your `PATH`, add a line resembling the following 
(substitute the paths
 with your local Android SDK installation's location):
 
 ```bash
-export 
PATH=${PATH}:/Development/android-sdk/platform-tools:/Development/android-sdk/tools
+export 
PATH=${PATH}:/Development/android-sdk/platform-tools:/Development/android-sdk/tools/bin:/Development/android-sdk/emulator

Review comment:
       ```suggestion
   export PATH=$PATH:$ANDROID_SDK_ROOT/platform-tools/
   export PATH=$PATH:$ANDROID_SDK_ROOT/cmdline-tools/latest/bin/
   export PATH=$PATH:$ANDROID_SDK_ROOT/emulator/
   ```

##########
File path: www/docs/en/10.x/guide/platforms/android/index.md
##########
@@ -167,7 +168,8 @@ reopen any command prompt windows after making changes to 
see them reflected.
 
     ```
     C:\Users\[your user]\AppData\Local\Android\Sdk\platform-tools
-    C:\Users\[your user]\AppData\Local\Android\Sdk\tools
+    C:\Users\[your user]\AppData\Local\Android\Sdk\tools\bin

Review comment:
       ```suggestion
       C:\Users\[your user]\AppData\Local\Android\Sdk\cmdline-tools\latest\bin
   ```

##########
File path: www/docs/en/dev/guide/platforms/android/index.md
##########
@@ -116,8 +116,9 @@ should be updated:
    installation
 2. Set the `ANDROID_SDK_ROOT` environment variable to the location of your 
Android
    SDK installation
-3. It is also recommended that you add the Android SDK's `tools`, `tools/bin`,
+3. It is also recommended that you add the Android SDK's `tools/bin`, 
`emulator`

Review comment:
       ```suggestion
   3. It is also recommended that you add the Android SDK's 
`cmdline-tools/latest/bin`, `emulator`
   ```

##########
File path: www/docs/en/dev/guide/platforms/android/index.md
##########
@@ -167,7 +168,8 @@ reopen any command prompt windows after making changes to 
see them reflected.
 
     ```
     C:\Users\[your user]\AppData\Local\Android\Sdk\platform-tools
-    C:\Users\[your user]\AppData\Local\Android\Sdk\tools
+    C:\Users\[your user]\AppData\Local\Android\Sdk\tools\bin

Review comment:
       ```suggestion
       C:\Users\[your user]\AppData\Local\Android\Sdk\cmdline-tools\latest\bin
   ```

##########
File path: www/docs/en/dev/guide/platforms/android/index.md
##########
@@ -133,7 +134,7 @@ To update your `PATH`, add a line resembling the following 
(substitute the paths
 with your local Android SDK installation's location):
 
 ```bash
-export 
PATH=${PATH}:/Development/android-sdk/platform-tools:/Development/android-sdk/tools
+export 
PATH=${PATH}:/Development/android-sdk/platform-tools:/Development/android-sdk/tools/bin:/Development/android-sdk/emulator

Review comment:
       ```suggestion
   export PATH=$PATH:$ANDROID_SDK_ROOT/platform-tools/
   export PATH=$PATH:$ANDROID_SDK_ROOT/cmdline-tools/latest/bin/
   export PATH=$PATH:$ANDROID_SDK_ROOT/emulator/
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to