erisu commented on a change in pull request #888:
URL: https://github.com/apache/cordova-lib/pull/888#discussion_r740956240
##########
File path: spec/cordova/plugin/remove.spec.js
##########
@@ -32,8 +32,7 @@ describe('cordova/plugin/remove', function () {
const cfg_parser_mock = function () {};
let package_json_mock;
const plugin_info_provider_mock = function () {};
- let plugin_info;
- package_json_mock = jasmine.createSpyObj('package json mock', ['cordova',
'dependencies']);
+ const plugin_info = jasmine.createSpyObj('package json mock', ['cordova',
'dependencies']);
Review comment:
This was already fix
##########
File path: spec/cordova/plugin/remove.spec.js
##########
@@ -32,8 +32,7 @@ describe('cordova/plugin/remove', function () {
const cfg_parser_mock = function () {};
let package_json_mock;
const plugin_info_provider_mock = function () {};
- let plugin_info;
- package_json_mock = jasmine.createSpyObj('package json mock', ['cordova',
'dependencies']);
+ const plugin_info = jasmine.createSpyObj('package json mock', ['cordova',
'dependencies']);
Review comment:
This was already fix. I probally pushed while you were writing this.
##########
File path: spec/plugman/util/metadata.spec.js
##########
@@ -32,6 +32,7 @@ const fsMock = {
};
// expect fsMock to only operate on fetchJsonPath
+// eslint-disable-next-line
Object.entries(fsMock).map(([key, fn]) => {
Review comment:
I just tested with `forEach` and it worked OK.
The warning was about how:
> Array.prototype.map() expects a return value from arrow function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
