erisu commented on a change in pull request #1186:
URL: https://github.com/apache/cordova-ios/pull/1186#discussion_r745284792
##########
File path: bin/templates/scripts/cordova/lib/versions.js
##########
@@ -49,9 +49,9 @@ exports.get_apple_xcode_version = () => {
return spawn('xcodebuild', ['-version'])
.then(output => {
const versionMatch = /Xcode (.*)/.exec(output);
-
- if (!versionMatch) return Promise.reject(output);
-
+ if (!versionMatch) {
+ throw new CordovaError('Could not determine Xcode version');
Review comment:
I am OK with the simplified message. Could the `output` contain
additional information that would help users debug why it failed?
If it could, maybe only include the output with the `--verbose` flag?
But I also don't know if the flag is visible here.
Anyways, I am good with these changes as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
