breautek commented on pull request #487:
URL:
https://github.com/apache/cordova-plugin-file/pull/487#issuecomment-967114246
Thanks for the review.
iOS is failing because of
> resolveLocalFileSystemURL on cdvfile://
✗ file.spec.147 should be able to resolve cdvfile
applicationDirectory fs root
- Expected [object Event] not to be defined.
This test case was failing since WKWebView was enforced, when cordova-ios@6
was released. So I don't consider this a blocker.
Android is failing because of
> Failed to install 'cordova-plugin-paramedic': Error: There was a conflict
trying to modify attributes with <edit-config> in plugin
cordova-plugin-paramedic. The conflicting plugin, undefined, already modified
the same attributes. The conflict must be resolved before
cordova-plugin-paramedic can be added. You may use --force to add the plugin
and overwrite the conflicting attributes.
Based on my local and manual testing using my [test
app](https://github.com/breautek/cordova-file-api30-test-app), I believe that
this PR is still an improvement over what is currently in master.
I'll merge in approximately 24 hours if there are no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
