raphinesse opened a new pull request #1193:
URL: https://github.com/apache/cordova-ios/pull/1193
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
This takes the changes from the first four commits of #1191 and adds a few
further simplifications in the affected code areas.
I pulled this out to reduce the scope of said PR and since I already
reviewed this part of the changes.
### Description
<!-- Describe your changes in detail -->
From #1191:
- Remove exported `updateSubprojectHelp`
- Remove exported `update_cordova_subproject`
- Renamed internal function `update_cordova_subproject` to
`updateCordovaSubproject`
- Refactored internal function `updateCordovaSubproject` to take in two
static arguments:
- `projectXcodePath` which is the path to project's xcodeproj
- `cordovaLibXcodePath` which is the path to the CordovaLib's xcodeproj.
(Note: it maybe a symbolic link when `--link` flag is added when installing
platform)
- Improved comments
- Removed excessive supportive internal methods
- `AbsParentPath`
- `AbsProjectPath`
- `relpath`
- `updateSubprojectHelp`
New:
- Cleanup `copyJsAndCordovaLib`
### Testing
<!-- Please describe in detail how you tested your changes. -->
`npm t`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
