brodybits opened a new pull request #1212: URL: https://github.com/apache/cordova-ios/pull/1212
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> I think it would be nice if we could support plugins that can handle an authentication challenge coming from the server, namely this callback on WKWebView: - https://developer.apple.com/documentation/webkit/wknavigationdelegate/1455638-webview?language=objc It would help support this functionality in a plugin that I maintain: - https://github.com/cordova-ccafix/cordova-plugin-client-certificate-support/issues/7 ### Description <!-- Describe your changes in detail --> This proposal adds a handler for a "didReceiveAuthenticationChallenge" callback from the WKWebView, and hands it off to a plugin if possible. I am raising this proposal now to see whether or not there is sufficient interest to justify any further work. A couple major TODO items: - [ ] cleanup logging - [ ] cleanup some comments - [ ] find a better completion strategy than "first plugin wins" **Alternative solution:** leave this functionality up to a native XHR plugin to support, which is good enough for my customer need right now ### Testing <!-- Please describe in detail how you tested your changes. --> Tested with this proposal on my plugin: - https://github.com/cordova-ccafix/cordova-plugin-client-certificate-support/tree/expose-auth-challenge-callback ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
