erisu commented on PR #167: URL: https://github.com/apache/cordova-plugin-device/pull/167#issuecomment-1089817333
@SailingSteve I noticed your PR had additional commits that were not related to your PR. I think there was an error with the rebase. I went ahead and created a new PR based on the latest main branch and cherry-picked your changes. I also pushed an extra commit to fix the failing GitHub Actions iOS tests. Your PR had the necessary `@available` check for iOS 14. But it was missing the `ifdef` block to ensure builds passed on older Xcode versions. Truthfully, I don't think people should use older versions of Xcode, for example, 11. But we needed Xcode 11 in GH Actions to access the iOS 12 and 13 simulators. My additional change here: https://github.com/apache/cordova-plugin-device/pull/167/commits/8938cf78de78178dd657273596ae48054ed51b6f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
