erisu commented on PR #168: URL: https://github.com/apache/cordova-plugin-device/pull/168#issuecomment-1094184071
Can you fill out the PR description, following the template? And if it is to close a ticket also link the ticket. For example: `Closes #<ticket number>` Also when I glanced the code, why are you stripping out the non-alphanumeric? What happens if the device name is in another language such as Japanese, Chinese, etc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
