BigBalli commented on PR #157: URL: https://github.com/apache/cordova-plugin-dialogs/pull/157#issuecomment-1094368325
Sorry, first time contributing to a Cordova repo. - I only tested the changes locally, didn't run specific automated tests (not sure what testing environment/workflow you usually use.) - prefixed the commit with platform. - not related to an existing issue - didn't update the documentation as this is indeed "design-breaking". Please let me know how to proceed, G > On Apr 9, 2022, at 10:40 PM, エリス ***@***.***> wrote: > > > Can you fill out the PR description, following the template? > > And if it is to close a ticket also link the ticket. For example: Closes # > > Reviewing the code, I have a feeling that this is considered as a breaking change. I feel that it will change the current default visual to red. Anyone who updates a patch or minor and have a visual or behavioral change would not be expected. > > Can you please confirm if this is break? > > Could there be a flag that determines the visual? > > Or is there a way it can be a configuration flag where the supply the color of choice else default to current? > > One would expect red is generally the negative action but it is also the users decision to fit their color format.. > > — > Reply to this email directly, view it on GitHub <https://github.com/apache/cordova-plugin-dialogs/pull/157#issuecomment-1094184749>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADIM3XQ2P6CJS5B3OYE6XDVEJSUJANCNFSM5TAD2YKQ>. > You are receiving this because you authored the thread. > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
