[
https://issues.apache.org/jira/browse/CB-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Bond-Caron updated CB-4609:
------------------------------------
Description:
I'm experimenting with a new plugin:
https://github.com/jbondc/cordova-plugin-gesture
To reproduce:
- Download https://github.com/jbondc/mtlhack-PhoneGap-gesture
1) Issue #1
<code>
cd cordova
plugin add https://github.com/jbondc/cordova-plugin-gesture
</code>
Since cordova.js isn't in the default path (www/resources/cordova.js), the
plugins gets copied to (www/plugins/) instead of (www/resources/js/plugins).
The same for 'cordova_plugins.js' (see attached screenshot)
Fix is likely in the cli/plugman to set find the appropriate root/base path to
cordova.js
2) Issue #2
Adding a plugin from a Windows path
<code>
cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture
</code>
In cordova_plugins.js, I see:
cordova.define('cordova/plugin_list', function(require, exports, module) {
module.exports = [
{
"file": "plugins\\org.apache.cordova.core.Gesture\\www\\gesture.js",
"id": "org.apache.cordova.core.Gesture.Gesture",
"clobbers": [
"cordova.gesture"
]
}
]
});
That path should be normalized to:
"plugins/org.apache.cordova.core.Gesture/www/gesture.js"
Fix is likely in cli/plugman, path.replace("\\", "/")
was:
I'm experimenting with a new plugin:
https://github.com/jbondc/cordova-plugin-gesture
Add the plugin from a path is successful:
>cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture
>cordova plugin list
[ 'org.apache.cordova.core.Gesture' ]
But removing it fails:
>cordova plugin rm F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture
[Error: Plugin "F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture" not added to
project.]
In cordova_plugins.js, I see:
cordova.define('cordova/plugin_list', function(require, exports, module) {
module.exports = [
{
"file": "plugins\\org.apache.cordova.core.Gesture\\www\\gesture.js",
"id": "org.apache.cordova.core.Gesture.Gesture",
"clobbers": [
"cordova.gesture"
]
}
]
});
Should that path be normalized to
"plugins/org.apache.cordova.core.Gesture/www/gesture.js"?
Not sure what's going on, I've looked at cli/plugman but couldn't find the code
where this happens.
Though 'plugin add' works, the end result on Android is cordova.gestures is
undefined.
08-18 01:55:03.082: D/chromium(1981): Unknown chromium error: -6
> add plugin from path - buggy on Windows
> ----------------------------------------
>
> Key: CB-4609
> URL: https://issues.apache.org/jira/browse/CB-4609
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, Plugman
> Affects Versions: 3.0.0
> Environment: Window 8, node v0.10.16
> Reporter: Jonathan Bond-Caron
> Assignee: Filip Maj
> Attachments: Result of 'plugin add'.jpg
>
>
> I'm experimenting with a new plugin:
> https://github.com/jbondc/cordova-plugin-gesture
> To reproduce:
> - Download https://github.com/jbondc/mtlhack-PhoneGap-gesture
> 1) Issue #1
> <code>
> cd cordova
> plugin add https://github.com/jbondc/cordova-plugin-gesture
> </code>
> Since cordova.js isn't in the default path (www/resources/cordova.js), the
> plugins gets copied to (www/plugins/) instead of (www/resources/js/plugins).
> The same for 'cordova_plugins.js' (see attached screenshot)
> Fix is likely in the cli/plugman to set find the appropriate root/base path
> to cordova.js
> 2) Issue #2
> Adding a plugin from a Windows path
> <code>
> cordova plugin add F:\Jonathan\GitHub\Cordova\cordova-plugin-gesture
> </code>
> In cordova_plugins.js, I see:
> cordova.define('cordova/plugin_list', function(require, exports, module) {
> module.exports = [
> {
> "file": "plugins\\org.apache.cordova.core.Gesture\\www\\gesture.js",
> "id": "org.apache.cordova.core.Gesture.Gesture",
> "clobbers": [
> "cordova.gesture"
> ]
> }
> ]
> });
> That path should be normalized to:
> "plugins/org.apache.cordova.core.Gesture/www/gesture.js"
> Fix is likely in cli/plugman, path.replace("\\", "/")
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
