breautek commented on code in PR #1431:
URL: https://github.com/apache/cordova-android/pull/1431#discussion_r873202090
##########
framework/cdv-gradle-config-defaults.json:
##########
@@ -1,6 +1,7 @@
{
"MIN_SDK_VERSION": 22,
"SDK_VERSION": 32,
+ "COMPILE_SDK_VERSION": 32,
Review Comment:
```suggestion
"COMPILE_SDK_VERSION": null,
```
We probably don't even need the `key` here at all, but might make it more
clear that `COMPILE_SDK_VERSION` is in fact, a valid variable. Unfortunately,
JSON doesn't support comments to really document this.
The `null` here is to make the value respond to falsey checks, since it is
safe to assume that all valid compile SDK values will be a positive integer.
See main comment for feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
