breautek commented on code in PR #1154:
URL: https://github.com/apache/cordova-android/pull/1154#discussion_r875401269
##########
spec/unit/prepare.spec.js:
##########
@@ -21,6 +21,8 @@ const rewire = require('rewire');
const path = require('path');
const CordovaError = require('cordova-common').CordovaError;
const GradlePropertiesParser =
require('../../lib/config/GradlePropertiesParser');
+const utils = require('../../lib/utils');
+const et = require('elementtree');
Review Comment:
`elementtree` is not actually declared by `cordova-android` as a
dependency.. The dependency is available through cordova-common but if
cordova-android needs to use it, it should have it's own npm install to avoid
the hidden dependency.
Can you `npm install elementtree` it for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
