erisu commented on PR #1441:
URL: https://github.com/apache/cordova-android/pull/1441#issuecomment-1168110534
> Looks good, but if I open the themes.xml in Android Studio it shows
"errors" because it doesn't understand the theme properties. The templates's
app/build.gradle should include `implementation
"androidx.core:core-splashscreen:${cordovaConfig.ANDROIDX_CORE_SPLASHSCREEN_VERSION}"`
so it understands the properties.
I added the dependency back the app as well.
> Also, current default delay is 3000 and it's being changed to -1, we have
to remember to document the "breaking" change
I am writting the splash screen docs as well. Since the plugin does not
support iOS or Android, the repo should not keep the docs anyways cause it will
lead to confusion on what support the plugin has. Those docs are being removed
from the plugin repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
