erisu commented on PR #1255: URL: https://github.com/apache/cordova-ios/pull/1255#issuecomment-1244839783
The code seems OK but I am unsure about the header license. We always use the Apache-2.0 license header. I know you are just copying the existing file contents from `cordova-plugin-splashscreen`, but I am even surprised that someone approved that. Also, the URL in the header comment, `https://github.com/apache/cordova-platform`, does not exist. I am not sure what should be done regarding the license but other then that, everything seems OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
