breautek opened a new pull request, #105: URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/105
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Browser ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fixes a failing test: ``` 1) cordova-plugin-screen-orientation-tests.tests >> window.screen.orientation should successfully lock and unlock screen orientation - Expected 'landscape-primary' to match /^portrait-/. ``` ### Description <!-- Describe your changes in detail --> The fix isn't truly a fix, but I don't think this issue is fixable. Previously this worked when the browser had no screen orientation API I believe, but modern versions of browser does. Just because the API exists however doesn't mean it's usable. Chrome on desktop will have the API exists but attempting to use it will result with a DOMException stating that the device isn't supported for locking. Additionally, testing this specific case is also problematic because the `lock` promise still gets resolved without rejection. You cannot catch or otherwise capture the DOMException. The DOMException is only ever printed to the JS console if you attempt to run the code without anything catching the promise (and the promise is then resolved later). It's not something I really like, but I don't think we have a better option, and I think this is better than having a false negative test. The old unit test still exists, but is hidden behind a `isLockable` flag. It's generally expected that mobile devices will have a working `lock` API, should the browser cordova app ever be loaded on a mobile browser, this however untested because I don't think we have a way to test browser platform on a mobile device. ### Testing <!-- Please describe in detail how you tested your changes. --> Ran cordova-paramedic manually. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
