RaddishIoW opened a new pull request, #244: URL: https://github.com/apache/cordova-electron/pull/244
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Electron (Mac/Win/Linux) ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Fixes #240. `electron-builder` allows options to be passed which enable auto-updating, among other things. Cordova-Electron was unnecessarily restricting the passing of options in the platform configs which prevented the use of these extra configuration options and features of `electron-builder`. The tests for cordova-electron were not catching this as they only tested each individual unit rather than the integrated code-flow. ### Description <!-- Describe your changes in detail --> Removing the function `__validateUserPlatformBuildSettings` and it's call in `lib/build.js` enables the use of these extra config keys. Any errors caused by incorrect config keys should be caught by `electron-builder` itself, negating the need for this check. ### Testing <!-- Please describe in detail how you tested your changes. --> ### Checklist - [ ] I've run the tests to see all new and existing tests pass - [ ] I added automated test coverage as appropriate for this change - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [ ] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
