breautek commented on PR #968: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/968#issuecomment-1292041883
> additionally, permissions must be granted as with this change there is no OS permission popup if permissions have not been allowed. Ok, so to be clear we have the following use cases: `Declared In Manifest` means the `<uses-permission>` entry for the permission in question was present in AndroidManifest. `Permission Granted Previously` means that the permission was granted by some means **outside** of the WebView. Either via another action that triggered the OS permission prompt, or the user used the OS App Permission settings to enable permission manually. `Permission OK'ed in IAB` means that the permission was granted and the in-app-browser webview was able to utilise the feature. ## Case 1 |Declared In Manifest|Permission Granted Previously|Permission OK'ed in IAB| |---|---|---| |:heavy_check_mark:|:heavy_check_mark:|:heavy_check_mark:| Because the `AndroidManifest` contains the permission declaration, and the user has somehow previously granted permission (which has yet to be revoked), the IAB was able to receive the permission and utilise the related features. ## Case 2 |Declared In Manifest|Permission Granted Previously|Permission OK'ed in IAB| |---|---|---| |:x:|:x:|:x:| Because the `AndroidManifest` does not contain the permission declaration, the user would have never been able to have the permission granted previously, and naturally neither would the IAB browser. ## Case 3 |Declared In Manifest|Permission Granted Previously|Permission OK'ed in IAB| |---|---|---| |:heavy_check_mark:|:x:|:x:| The `AndroidManifest` does contain the permission declaration, but the user has yet to trigger a OS permission prompt somehow and does not have the permission currently granted. IAB is unable to trigger a permission prompt, so it will also fail to receive the grant. Do these case results correctly represent the behaviour as the PR stands now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
