breautek commented on PR #587: URL: https://github.com/apache/cordova-cli/pull/587#issuecomment-1329123575
> Would be nice to upgrade update-notifier to at least next major vers ^6.0.2 It's kind of planned but it is a huge breaking change because the package has turned into pure ESM which isn't compatible with CommonJS code. So our options is to: ##### Drop the package altogether and hopefully find a replacement Might be a stopgap solution. The update notifier is nice-to-have, and honestly wouldn't be too difficult to implement a notifier ourselves. But the author of the package is like a NPM module rock star with literally thousands of commonly used packages and he's been converting all of his packages. I'm sure Cordova has other dependencies from the same author that we will eventually run into a similar issue with. ##### Convert Cordova to ESM which will be a quite a time consuming process. Is likely the best approach forward but it's very time consuming because as you migrate packages to ESM, it will break any dependents that are trying to use it in a CommonJS style (via `require`). So the entire Cordova framework effectively will need to become ESM modules, and then of course it will break third-party tooling that has Cordova has a dependency. ##### Introduce build tools into our Cordova repos to convert ESM packages back to commonjs. I know this doesn't have good support with the community. It introduces complexities and makes it so you can't simply install a dev/test version from github (cause ideally generated files will be git ignored). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
