pjoriginal opened a new pull request, #549: URL: https://github.com/apache/cordova-plugin-file/pull/549
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Electron ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> This is required so that cordova electron can have a working file plugin <!-- If it fixes an open issue, please link to the issue here. --> #334 #312 #477 ### Description <!-- Describe your changes in detail --> The base implementation has two things. 1. Scripts to add and remove node implementations done in files `cdv-electron-main.js` and `cdv-electron-preload.js`. Since the scripts look for comments, and remove code between the comments on plugin remove, we should be good as long as the dev doesn't mess those up. These scripts are added to support [Context Isloation](https://www.electronjs.org/docs/latest/tutorial/context-isolation/) that has been encouraged in electron@^3.0. The `fs` required can be called from `window.cordovaFilePlugin.function`. I had to tweak some changes because the return value objects have their methods removed. ### Testing <!-- Please describe in detail how you tested your changes. --> I've tested them on my personal projects. Will write an exclusive test project if necessary, ### Checklist - [X ] I've run the tests to see all new and existing tests pass - [X ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [X] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [X] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
