cxcxcxcx commented on issue #1465: URL: https://github.com/apache/cordova-android/issues/1465#issuecomment-1353254846
> The blank space color might be configurable via the BackgroundColor preference. For my device, it's black, but also the same color as the phone edge. I didn't notice it until I upgraded to cordova-android 11. It's probably a fallback mechanism that phone manufactuers considered to support older apps. > We could add a preference to configure this, but if a workaround can be done simply by providing a resource-file, I think I'd prefer documenting that approach rather than adding a feature option that we would have to maintain thereafter, especially since this feature is just for a workaround to an upstream chromium bug. Yeah, it's weird to workaround an upstream bug. However, because cordova is largely about enabling HTML5 on native apps, the upstream bug sounds a deal-breaker: almost all apps will suffer, but developers may not realize just because they don't have test devices with cutouts. Forcing not using the cutout space is not ideal, but it's reverting to the cordova-android 10 behavior. Power users can still customize using hooks, and the default behavior will be decent. > > @cxcxcxcx If you could provide a full example of the workaround including the contents of `resources/android/xml/themes_v27.xml`, I think that would be helpful. I find how to apply the workaround from [#1465 (comment)](https://github.com/apache/cordova-android/issues/1465#issuecomment-1216730224) is not completely clear. Later I can take it and document it to the [Android Quirks](https://cordova.apache.org/docs/en/11.x/guide/platforms/android/index.html#android-quirks) section. I cloned the `themes.xml` file: ``` $ cat resources/android/xml/themes_v27.xml <?xml version='1.0' encoding='utf-8'?> <resources> <style name="Theme.App.SplashScreen" parent="Theme.SplashScreen.IconBackground"> <item name="windowSplashScreenBackground">@color/cdv_splashscreen_background</item> <item name="windowSplashScreenAnimatedIcon">@drawable/ic_cdv_splashscreen</item> <item name="windowSplashScreenAnimationDuration">200</item> <item name="postSplashScreenTheme">@style/Theme.AppCompat.NoActionBar</item> <item name="android:windowLayoutInDisplayCutoutMode">never</item> </style> </resources> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
