breautek commented on issue #906: URL: https://github.com/apache/cordova-lib/issues/906#issuecomment-1368553992
> I am a +1 to remove the test, is that your recommendation? No, I don't think the test should be removed, the act of testing adding local folders as a platform target should be something that is tested as that is a supported way of using Cordova... and I believe that is the intended test scenario in Test#012. However, it should be testing a valid directory as a platform target (e.g. not the contents of an NPM packed tarball but rather a git cloned directory, for example). I'm not sure what is involved on making that happen, so we could disable the test with a comment pointing to this ticket for context until we do find a proper solution. Or if we decide that an unpacked tarball folder should be a valid target, then we will probably have to fix `cordova-android`, but I'd rather call that an unsupported target (install the tarball itself instead). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
