erisu commented on code in PR #905:
URL: https://github.com/apache/cordova-lib/pull/905#discussion_r1065927083
##########
.github/workflows/ci.yml:
##########
@@ -46,6 +46,8 @@ jobs:
env:
CI: true
- - uses: codecov/codecov-action@v3
+ - name: upload coverage
+ if: success()
+ uses: codecov/[email protected]
with:
- fail_ci_if_error: true
+ name: ${{ runner.os }} node.js ${{ matrix.node-version }}
Review Comment:
Would it be better written this way?
```yaml
- uses: codecov/codecov-action@v3
if: success()
with:
name: ${{ runner.os }} node.js ${{ matrix.node-version }}
```
I dont think the first `name` field is required as we are not appending any
unique values to the field.
I feel the default name is efficient. Example: `Run
codecov/codecov-action@v3`
Also, do you want to use `codecov/codecov-action@v3` or
`codecov/[email protected]`?
* `v3` always fetch the latetst released version of `3.x`.
* `v3.1.1` will always be locked in at the same version and not fetch any
fixes. If anything breaks, we will have to update manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
