ndrake commented on code in PR #882:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/882#discussion_r1096271723
##########
src/android/InAppBrowser.java:
##########
@@ -534,6 +534,16 @@ public void onPageFinished(WebView view, String url) {
dialog.dismiss();
dialog = null;
}
+
+ // Fix for webView window not being destroyed
correctly causing memory leak
+ //
(https://github.com/apache/cordova-plugin-inappbrowser/issues/290)
+ if (url.equals(new String("about:blank"))) {
Review Comment:
The call to `new String()` is unnecessary, consider doing: `if
(url.equals("about:blank")) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
