breautek commented on PR #112: URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/112#issuecomment-1439053394
Fails the test for older Android platforms due to syntax errors. ``` 02-21 20:15:10.641 I/chromium( 3672): [INFO:CONSOLE(45)] "Uncaught SyntaxError: Unexpected identifier", source: http://localhost/plugins/cordova-plugin-screen-orientation/www/screenorientation.js (45) ``` So it will be intended to be merged as a breaking change, after Android 5.1 support is dropped. We may need to test to see what the minimum android version we can support with their default shipped chrome versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
