[
https://issues.apache.org/jira/browse/CB-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757173#comment-13757173
]
Peter commented on CB-4588:
---------------------------
Thanks for the change, but shouldn't the new description say
{quote}
Array of strings specifying button labels. _(Array)_ (Optional, defaults to
[`OK,Cancel`])
{quote}
(with the square brackets) instead of
{quote}
Array of strings specifying button labels. _(Array)_ (Optional, defaults to
`OK,Cancel`)
{quote}
> Documentation for notification.confirm should say to pass buttonLabels as
> Array
> -------------------------------------------------------------------------------
>
> Key: CB-4588
> URL: https://issues.apache.org/jira/browse/CB-4588
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Docs
> Affects Versions: 2.9.0
> Reporter: Peter
> Assignee: Lorin Beer
> Priority: Minor
>
> Compare navigator.notification.confirm and navigator.notification.prompt.
> Both APIs allow caller to specifiy *buttonLabels* as 4th parameter, but
> confirm expects a comma separated String and prompt expects an array. The
> parameter passing mechanism should be consistent for these similar APIs.
> It looks like the cordova.js is already handling the scenario, because it
> says:
> {code}
> console.log("Notification.confirm(string, function, string, string) is
> deprecated. Use Notification.confirm(string, function, string, array).");
> {code}
> But the documentation for navigator.confirm is out-of-step with the code; it
> should be updated to say to pass Array, not String.
> Seems related to CB-1933
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
