dpogue commented on code in PR #1295:
URL: https://github.com/apache/cordova-ios/pull/1295#discussion_r1165721228
##########
tests/CordovaLibTests/CordovaLibTests.xcodeproj/project.pbxproj:
##########
@@ -551,7 +563,7 @@
PUBLIC_HEADERS_FOLDER_PATH = include/Cordova;
SDKROOT = iphoneos;
SKIP_INSTALL = YES;
- SWIFT_OBJC_BRIDGING_HEADER =
"__PROJECT_NAME__/Bridging-Header.h";
+ SWIFT_OBJC_BRIDGING_HEADER =
"CordovaLibApp/Bridging-Header.h";
Review Comment:
yes, in the test project, the folder name is `CordovaLibApp`. Previously
this didn't cause problems because we had no Swift code in the tests, but now
it needs to be accurate.
##########
tests/CordovaLibTests/CordovaLibTests.xcodeproj/project.pbxproj:
##########
@@ -604,7 +616,7 @@
PUBLIC_HEADERS_FOLDER_PATH = include/Cordova;
SDKROOT = iphoneos;
SKIP_INSTALL = YES;
- SWIFT_OBJC_BRIDGING_HEADER =
"__PROJECT_NAME__/Bridging-Header.h";
+ SWIFT_OBJC_BRIDGING_HEADER =
"CordovaLibApp/Bridging-Header.h";
Review Comment:
yes, in the test project, the folder name is `CordovaLibApp`. Previously
this didn't cause problems because we had no Swift code in the tests, but now
it needs to be accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
