erisu commented on code in PR #1609:
URL: https://github.com/apache/cordova-android/pull/1609#discussion_r1180628389
##########
templates/project/AndroidManifest.xml:
##########
@@ -46,5 +46,8 @@
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
+ <provider android:name="androidx.core.content.FileProvider"
android:authorities="${applicationId}.provider" android:exported="false"
android:grantUriPermissions="true">
Review Comment:
```suggestion
<provider android:name="androidx.core.content.FileProvider"
android:authorities="${applicationId}.cdv.core.file.provider"
android:exported="false" android:grantUriPermissions="true">
```
Make the authorities' name unique to prevent collisions.
The camera plugin had used the same name at one point
`android:authorities="${applicationId}.provider"` and had a collision with
another plugin that used the same name.
Seeing how this had happened in the past, with the same authorities' name
that you defined above, proves that there are potential plugins out there with
the same name. I expect a collision.
Using my suggestion should be good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
