erisu commented on code in PR #1319:
URL: https://github.com/apache/cordova-docs/pull/1319#discussion_r1212522678
##########
www/docs/en/dev/plugin_ref/spec.md:
##########
@@ -55,12 +55,12 @@ The child elements of the `<engines>` element specify
versions of Apache Cordova
>is in a plugin's `package.json`. See [specifying Cordova
>dependencies](../guide/hybrid/plugins/index.html#specifying-cordova-dependencies)
>for more information
-Attributes(type) <br/> <span class="sub-header">Only for platform:</span> |
Description
+Attributes | Description
---------------- | ------------
-name(string) | *Required* <br/> Name of the engine. Here are the default
engines that are supported : <ul><li> `cordova` </li> <li> `cordova-plugman`
</li> <li> `cordova-android` </li> <li> `cordova-browser` </li> <li>
`cordova-ios` </li> <li> `cordova-windows` </li> <li> `cordova-osx` </li> <li>
`windows-os` </li> <li> `android-sdk` (returns the highest Android api level
installed) </li> <li> `windows-sdk` (returns the native windows SDK version)
</li> <li> `apple-xcode` (returns the xcode version) </li> <li> `apple-ios`
(returns the highest iOS version installed) </li> <li> `apple-osx` (returns the
OSX version) </li> You can also specify a custom framework apart from the
default ones.
-version(string) | *Required* <br/> The version that your framework must have
in order to install. Semver syntax is supported.
-scriptSrc(string) | **For custom frameworks only** <br/> *Required* <br/> The
script file that tells plugman the version of the custom framework. Ideally,
this file should be within the top level directory of your plugin directory.
-platform(string) | **For custom frameworks only** <br/> *Required* <br/> The
platforms your framework supports. You may use the wildcard `*` to say
supported for all platforms, specify multiple with a pipe character like
`android|ios` or just a single platform like `android`.
+name<br />{% cdv_vartype string %}| *Required* <br/>Name of the engine. Here
are the default engines that are supported: <ul><li>`cordova`</li><li>
`cordova-plugman`</li><li>`cordova-android`</li>
<li>`cordova-browser`</li><li>`cordova-ios`</li><li>`windows-os`</li><li>`android-sdk`
(returns the highest Android api level installed) </li><li> `apple-xcode`
(returns the xcode version) </li><li>`apple-ios` (returns the highest iOS
version installed)</li><li>`apple-osx` (returns the macOS version)</li></ul>
You can also specify a custom framework apart from the default ones.
Review Comment:
```suggestion
name<br />{% cdv_vartype string %}| *Required* <br/>Name of the engine. Here
are the default engines that are supported: `cordova`, `cordova-plugman`,
`cordova-android`, `cordova-browser`, `cordova-ios`, `windows-os`,
`android-sdk` (returns the highest Android api level installed) , `apple-xcode`
(returns the xcode version), `apple-ios` (returns the highest iOS version
installed), `apple-osx` (returns the macOS version). You can also specify a
custom framework apart from the default ones.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
