erisu commented on code in PR #214:
URL:
https://github.com/apache/cordova-plugin-media-capture/pull/214#discussion_r1269396966
##########
www/CaptureVideoOptions.js:
##########
@@ -27,8 +27,6 @@ var CaptureVideoOptions = function () {
this.limit = 1;
// Maximum duration of a single video clip in seconds.
this.duration = 0;
- // Video quality parameter, 0 means low quality, suitable for MMS
messages, and value 1 means high quality.
- this.quality = 1;
Review Comment:
Can this remain set to 1?
I suspect removing this could affect Android. But I have not dug into
Android's code to confirm what happens internally.
With the current plugin, I suspect the following:
* Android default 1 (high)
* iOS hardcoded at medium.
Since I am looking to prepare a major release, we could just keep the
default as `1` (high) to not potentially change Android and to make iOS match
with Android.
This PR would introduce new features and a singular breaking change to only
iOS (one platform).
Looking forward to getting this PR merged in for next major release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
