breautek commented on code in PR #588:
URL:
https://github.com/apache/cordova-plugin-file/pull/588#discussion_r1277975270
##########
types/index.d.ts:
##########
@@ -63,7 +63,7 @@ interface Entry {
/** The full absolute path from the root to the entry. */
fullPath: string;
/** The file system on which the entry resides. */
- filesystem: FileSystem;
+ filesystem: FileSystemCordova;
Review Comment:
`CDVFileSystem` here
##########
types/index.d.ts:
##########
@@ -42,7 +42,7 @@ interface Window {
}
/** This interface represents a file system. */
-interface FileSystem {
+interface FileSystemCordova {
Review Comment:
`CDVFileSystem` here
##########
types/index.d.ts:
##########
@@ -17,7 +17,7 @@ interface Window {
requestFileSystem(
type: LocalFileSystem,
size: number,
- successCallback: (fileSystem: FileSystem) => void,
+ successCallback: (fileSystem: FileSystemCordova) => void,
Review Comment:
Generally when we prefix, we use `CDV` prefix. Prefixes aren't normally
done... but they are done by convention in iOS code, so I think it might make
sense to replicate that for consistency here.
`CDVFileSystem` might be a better name for the type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
