HazzMan2409 commented on code in PR #995:
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/995#discussion_r1288884046
##########
src/ios/CDVWKInAppBrowser.m:
##########
@@ -778,6 +778,14 @@ - (void)createViews
[self.view addSubview:self.webView];
[self.view sendSubviewToBack:self.webView];
+#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 160400
+ // Set "inspectable" to true for backwards compatibility with iOS <= 16.3,
but allow an override.
+ // Preferably this would be set to the default "NO" or wrapped in an
"#ifdef DEBUG",
+ // but that would be a breaking change and needs to wait till a (next)
major release.
+ if (@available(iOS 16.4, *)) {
+ self.webView.inspectable = [settings
cordovaBoolSettingForKey:@"InspectableWebview" defaultValue:YES];;
Review Comment:
Double semi-colon on here cause compilation failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
