breautek commented on issue #201:
URL: https://github.com/apache/cordova-common/issues/201#issuecomment-1674732099

   The entire system that powers the `<config-file>` and `<edit-config>` 
doesn't work very well, and there is a lot of known issues surrounding it.
   
   If you're able to determine a solution, even if it's not perfect then a PR 
would be appreciated...
   
   Most issues starts to occur when there are more than 1 thing trying to 
modify the same note, or part of the node tree. Your issue doesn't appear to be 
that however given that it looks like you have a sample project with your 
sample plugin.
   
   The issue appears to be more on the fact that on plugin uninstall, it isn't 
"cleaning" up after itself.
   
   If I recall correctly, when you have a munge operation:
   
   it will add a data point like this:
   
   ```
   {
        "xml": "<uses-permission 
android:name=\"android.permission.WRITE_EXTERNAL_STORAGE\" />",
       "count": 1
   },
   ```
   
   and it's suppose to increment the `count`. This I believe is to support 2 
plugins potentially trying to make hte same modification. e.g. if you add 
plugin A and plugin B that has the same edit-config, it should have a `count` 
of 2. If you remove plugin B, then the `count` I think is suppose to decrement. 
If the `count` reaches 0, it suppose to signal to remove the modification from 
the target file. At least I believe that is how it's **suppose** to work.
   
   Perhaps on plugin add, it's incrementing more than once?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to