breautek commented on code in PR #839:
URL:
https://github.com/apache/cordova-plugin-camera/pull/839#discussion_r1299977871
##########
src/android/CameraLauncher.java:
##########
@@ -1312,20 +1312,39 @@ public void onScanCompleted(String path, Uri uri) {
}
public void onRequestPermissionResult(int requestCode, String[]
permissions,
- int[] grantResults) {
- for (int r : grantResults) {
- if (r == PackageManager.PERMISSION_DENIED) {
- this.callbackContext.sendPluginResult(new
PluginResult(PluginResult.Status.ERROR, PERMISSION_DENIED_ERROR));
- return;
+ int[] grantResults) throws
JSONException {
+ String version = android.os.Build.VERSION.RELEASE;
+ if(Integer.parseInt(version) <= 13)
+ {
+ if(PermissionHelper.hasPermission(this,
Manifest.permission.CAMERA)) {
Review Comment:
`CAMERA` permission is normally not required, but there is a caveat with the
[ACTION_MEDIA_CAPTURE](https://developer.android.com/reference/android/provider/MediaStore#ACTION_IMAGE_CAPTURE)
API.
> Note: if you app targets
[M](https://developer.android.com/reference/android/os/Build.VERSION_CODES#M)
and above and declares as using the
[Manifest.permission.CAMERA](https://developer.android.com/reference/android/Manifest.permission#CAMERA)
permission which is not granted, then attempting to use this action will
result in a
[SecurityException](https://developer.android.com/reference/java/lang/SecurityException).
Normally the `CAMERA` permission is only for gaining access to the camera
hardware so it's not normally needed when intents. But if something, or someone
adds the `CAMERA` permission to the app's manifest, then the `CAMERA`
permission needs to be granted for the intent to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
