breautek commented on issue #1381: URL: https://github.com/apache/cordova-ios/issues/1381#issuecomment-1769034808
Most of our "settings" would belong in `config.xml` but given this is more of a developer/build config, rather than an app config, an environment variable might be the way to go... If we do use an environment variable, I think it's important to make a distinct variable per platform, like your suggested `CORDOVA_DEFAULT_IOS_TARGET`. What you could do is maybe prepare a small document or some blurb of text describing what you plan to implement behaviour wise and subscribe/write to our [Dev Mailing List](https://cordova.apache.org/contact/) with your intent. This will put more visibility among cordova contributors as GH notifications can be a bit noisy. (Just know the mailing list is for discussions regarding development & management of the cordova project only) It will probably be important to limit that scope to behaviour rather than code (code review is much easier on a PR) but what I'd probably recommend is something like: 1. If `--target` is present, then set target to `--target` value. 2. Else if `CORDOVA_DEFAULT_IOS_TARGET` exists, then set target to `CORDOVA_DEFAULT_IOS_TARGET` value 3. else; fallback to `getDefaultSim()` (or whatever the method is called) I'm not very familiar with the part of code that handles the `--target`... But if the code is primarily in the platform (e.g. `cordova-ios`, then it's safe to hard-code `CORDOVA_DEFAULT_IOS_TARGET` environment variable lookup), otherwise you might have to incorporate the flow of choosing `CORDOVA_DEFAULT_IOS_TARGET` over some other platform target. Give 48-72 hours to let people object to your plans. If there are any objections the mailing thread is Apache official way to resolve those kinds of disputes. And if there is an agreement (either explicitly or lazily by silence) then a PR could be created. This might save time building a PR that won't get accepted without drastic changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
