[
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile closed CB-13309.
-----------------------------
Resolution: Won't Do
closing as won't do, while I think it's a good idea, it makes the plugin hard
to maintain, despite you don't have to worry about the java files in plugin.xml
anymore, you have to keep the android project up to date updating the
targetSDK, compileSDK, gradle, etc. And we can't ship gradle files, so the
native project won't compile out of the box.
> Make InAppBrowser a Library Module for easier maintenance
> ---------------------------------------------------------
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-inappbrowser
> Reporter: Joey Robert Bowser
> Priority: Major
>
> We currently just copy in Java files directly in a project, but that has some
> major problems with layouts and resources. Now that Android allows Library
> Projects, we can now add modules as plugins and allow for certain plugins
> which require layouts (like the InAppBrowser) to define them in XML instead
> of programmatically, which will allow for a lot of code to be deleted from
> the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso
> Integration Tests to plugins so that we can actually test plugin changes the
> same way we run native tests on Android with the Android Test Project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
