breautek commented on PR #873: URL: https://github.com/apache/cordova-plugin-camera/pull/873#issuecomment-1847761852
This PR doesn't compile on android: ``` > Task :app:compileDebugJavaWithJavac FAILED /private/var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/tmp-6830-P1sEoh8XyXcJ/platforms/android/app/src/main/java/org/apache/cordova/camera/CameraLauncher.java:361: error: cannot find symbol this.cordova.getActivity().finishActivity((CAMERA + 1) * 16 + returnType + 1); ^ symbol: variable returnType location: class CameraLauncher /private/var/folders/3s/vfzpb5r51gs6y328rmlgzm7c0000gn/T/tmp-6830-P1sEoh8XyXcJ/platforms/android/app/src/main/java/org/apache/cordova/camera/CameraLauncher.java:[362](https://github.com/apache/cordova-plugin-camera/actions/runs/7110255438/job/19459961261?pr=873#step:9:366): error: cannot find symbol this.cordova.getActivity().finishActivity((PHOTOLIBRARY + 1) * 16 + returnType + 1); ^ symbol: variable returnType location: class CameraLauncher Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. 2 errors ``` Additionally there are lint issues present in this PR: ``` /home/runner/work/cordova-plugin-camera/cordova-plugin-camera/www/Camera.js Error: 158:1 error Unexpected tab character no-tabs Error: 158:1 error Expected indentation of 4 spaces but found 1 tab indent ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org