dpogue opened a new pull request, #1457: URL: https://github.com/apache/cordova-ios/pull/1457
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> Sorta depends on https://github.com/apache/cordova-ios/pull/1455 first because there will be merge conflicts that need resolving. ### To Do - [ ] Confirm the template Xcode project has all the right files (I think it might be missing the Staging folder, and maybe one of the build.xcconfig files) ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Closes https://github.com/apache/cordova-ios/issues/674. Closes https://github.com/apache/cordova-ios/issues/904. ### Description <!-- Describe your changes in detail --> Replace the existing template project with one that uses modern Swift classes, storyboards, and customizes the `CDVViewController` using storyboard properties rather than relying on specifically-named colour variables being globally available. This is one step that should make it easier and much more pleasant for people wanting to embed `CDVViewController` instances within their existing iOS apps. ### Testing <!-- Please describe in detail how you tested your changes. --> Built to a simulator. All existing tests pass. ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
