dpogue opened a new pull request, #1467:
URL: https://github.com/apache/cordova-ios/pull/1467

   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Closes GH-1365.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Calling `new Podfile(...)` will create an empty Podfile in the project if it 
does not exist. If we don't have any pods to add for a given plugin, we can 
skip doing anything at all with the Podfile and avoid needlessly creating it.
   
   Note: I moved an `if` block to do an early return, which de-indented the 
majority of the code in that function. This PR is easier to review with 
whitespace changes disabled.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Tested manually by creating a new project and installing the 
`cordova-plugin-inappbrowser` and confirmed that no Podfile was present in the 
`platforms/ios` directory.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to