dpogue opened a new pull request, #1472: URL: https://github.com/apache/cordova-ios/pull/1472
### Platforms affected ios ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> Some of the code in CordovaLib dates back to the very early dates of cordova-ios and an era when iOS 4 introduced breaking changes and Objective C was having new language features introduced (yes, Cordova actually predates the transition to ObjC ARC 💀). Nowadays there are some conventions that are pretty standard (like `instancetype` for initializer methods) that we should aim to adopt for consistency. Also, refactored `CDVConfigParser` to avoid needing a round-trip through weird `CDVViewController` methods to do anything useful. I can split this commit out into its own PR if that makes it easier for review. ### Description <!-- Describe your changes in detail --> * Various small ObjC cleanups * Add some static methods to `CDVConfigParser` to facilitate parsing config.xml ### Testing <!-- Please describe in detail how you tested your changes. --> All existing unit tests pass. ### Checklist - [x] I've run the tests to see all new and existing tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
