dpogue opened a new pull request, #1474: URL: https://github.com/apache/cordova-ios/pull/1474
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected iOS ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> A bunch of properties on CDVViewController were publicly exposing internal state that should be private to the instance. We can't completely solve that problem right now, but we can make the API boundary more clearly delineated. ### Description <!-- Describe your changes in detail --> Clean up properties/ivars in CDVViewController Rename wwwFolderName to webContentFolderName so that it gets a useful label in Xcode's Interface Builder for people embedding CDVViewController inside their own apps (IB showed it as "Www Folder Name" and there's no way to alias that, so now it shows up as "Web Content Folder Name") ### Testing <!-- Please describe in detail how you tested your changes. --> Existing tests pass. ### Checklist - [x] I've run the tests to see all new and existing tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
